Clean session disconnect event even if an error occurs #625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for the PR! 🙇 Will test it |
|
@enricop89 it works perfectly Thanks a ton! |
Contributor
|
@enricop89 @abdulajet will this PR be merged? |
Contributor
|
Why is this PR not merged? |
Contributor
|
Is there any chance of this being merged? #271 Is a long-standing issue which, despite having been closed, is still a real problem. |
|
We really need this to be merged. |
Contributor
|
@abdulajet @jeffswartz is it possible to give a little bit more attention to react-native. |
|
@jeffswartz could you please review this PR? As stated by others, this issue is a long-standing one, and we currently have to use this patch for our production application. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #271.
Credits: @vineus