fix: moved cleanup to a delegate methods #909
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving memory management and state cleanup for publisher and subscriber objects in the iOS OpenTok React Native integration. The main changes ensure that publishers and subscribers are properly removed from shared state dictionaries, reducing the risk of memory leaks or stale references.
State cleanup improvements:
nilwithremoveValue(forKey:)when removing publishers and publishing status fromOTRN.sharedStateinOTRNPublisherComponentView.swift, ensuring dictionary entries are properly deleted.removeValue(forKey:)for publishers in the publisher delegate'sstreamDestroyedhandler to guarantee publisher cleanup.Subscriber management enhancements:
OTRN.sharedState.subscriberswhen a stream is destroyed inOpentokReactNative.swift, ensuring subscribers are cleaned up along with their streams.Redundant code removal:
removeValue(forKey:)for publishers and subscribers inOpentokReactNative.swift, as these are now handled more appropriately elsewhere in the code. [1] [2]Contributing checklist
Solves issue(s)