Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test exception in handler #50

Merged

Conversation

pavolloffay
Copy link
Collaborator

@pavolloffay pavolloffay commented Nov 14, 2017

Related to #13

@pavolloffay pavolloffay mentioned this pull request Nov 14, 2017
Assert.assertEquals(500, response.getStatus());

List<MockSpan> mockSpans = mockTracer.finishedSpans();
// TODO jax-rs interceptors do not trace this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth referencing github issue here that will track adding this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@pavolloffay pavolloffay merged commit 3cfb56e into opentracing-contrib:master Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants