Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

Cover span handof scenarios in a bit more detail #214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rbtcollins
Copy link

This came up because I had to ask in gitter.im about the details here, so I thought I'd capture it for everyone.

This came up because I had to ask in gitter.im about the details here, so I thought I'd capture it for everyone.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.09% when pulling 9c94df0 on rbtcollins:patch-1 into e000eb0 on opentracing:master.

@yurishkuro
Copy link
Member

@rbtcollins note that continuations are most likely going away in 0.31

@rbtcollins
Copy link
Author

@yurishkuro sure, but doing both of these things has to remain possible right? So the merge of the Scopes or whatever should have the same, but updated docs in it. What do you think of the docs? Are they accurate? Can has merge? :)

@yurishkuro
Copy link
Member

I think my point is that in 0.31 the Continuation is going away because it was demonstrated that most async scenarios can be handled without continuations and ref counting. The Scope in 0.31 is functionally equivalent to ActiveSpan in 0.30. That's why I questioned the value of writing examples that still utilize continuations rather than writing them using ActiveSpan only.

@rbtcollins
Copy link
Author

Well, its not clear to me yet how we'll integrate that in in Xenon. We just merged 0.30.0 instrumentation, and when I went looking at the 0.31 branch there was no updated user docs; so I figured updating the current docs was reasonable to cover this use case, and then when the 0.31 docs are updated, whoever is doing that can update this as well.

@tedsuo
Copy link
Member

tedsuo commented Nov 14, 2017

@rbtcollins I'm sure we'll do more copy editing, but the docs are updated: https://github.com/opentracing/opentracing-java/tree/v0.31.0

@carlosalberto
Copy link
Collaborator

Hey @rbtcollins

Sorry for the long delayed ping. Wondering if we should discard these changes, now that we don't use Continuations as part of the main API (we still have AutoFinishScopeManager, but that is part of opentracing-util and does extra things not covered by it ;) )

Let us know.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants