Minor Pattern Viewer Overhaul #1467
Conversation
There was a problem hiding this comment.
Overall this is quite a good cleanup. Well implemented. Just a few small issues!
However, I would like to maybe ask for the old colored background mode to be configurable (even if off by default)? Just because on some configurations which have a whiter map the amount of white on the screen is pretty glaring, especially when the nearby view sidebar, the itinerary selection sidebar, and schedule view sidebar each have strong background colors.
| <HeaderText className="header-text"> | ||
| <FormattedMessage id="components.TripViewer.header" /> | ||
| </HeaderText> | ||
| <div className="back-button-container"> |
There was a problem hiding this comment.
Alignment here is very off
There was a problem hiding this comment.
Cleaner now! And I fixed the header on mobile
There was a problem hiding this comment.
I think it's still not quite right!
There was a problem hiding this comment.
Is this spacing issue related? 
There was a problem hiding this comment.
Oh weird, egg on my face i was only looking at chrome. I removed the display: content on the heading which fixed this issue. It did add a small difference in the percy tests for the route viewer. If we want, I can add a v small margin to the Route viewer header to have it match the tests more closely, but it does feel like a pretty insubstantial change.
| </h1> | ||
| </div> | ||
| )} | ||
| </h1> |
There was a problem hiding this comment.
Is there any way to hide the shadow if there is no overflow? It's quite awkward
There was a problem hiding this comment.
You may need to pull the branch? This shadow is gone, thats what this was referring to #1467 (comment)
There was a problem hiding this comment.
Yes apologies! This is an old screenshot but the issue is still present -- the new non-shadowey line is still there!
What component is this? |
Seeing this when clicking a route from the route viewer. As the pattern viewer is loading |
Description:
hideBackButtonprop (it didn't do anything)Also I removed the background color on the pattern viewer and changed the route color into more of an accent color. I also moved the operator and external link to the bottom of the page (in line with some previous designs) but I am open to feedback.
RouteRowDetailscomponent that can be used in the route viewer and pattern viewerPR Checklist: