Skip to content

Conversation

@amy-corson-ibigroup
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup commented Sep 4, 2025

Description:

  • Remove the hideBackButton prop (it didn't do anything)
  • Pattern viewer back button on by default (because switching between patterns means you can't use the browser back button to return to route viewer)
  • Trip viewer back button on by default (intuitive to return to the itinerary)
  • Other back buttons fully removed
  • Created a back button component that can be used in several places

Also I removed the background color on the pattern viewer and changed the route color into more of an accent color. I also moved the operator and external link to the bottom of the page (in line with some previous designs) but I am open to feedback.

  • Removed the route color background
  • Created a RouteRowDetails component that can be used in the route viewer and pattern viewer

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?
Before After (default) After (with useRouteColorAsBackground)
image image image

@miles-grant-ibigroup miles-grant-ibigroup self-assigned this Sep 5, 2025
Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is quite a good cleanup. Well implemented. Just a few small issues!

However, I would like to maybe ask for the old colored background mode to be configurable (even if off by default)? Just because on some configurations which have a whiter map the amount of white on the screen is pretty glaring, especially when the nearby view sidebar, the itinerary selection sidebar, and schedule view sidebar each have strong background colors.

Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awkward -- the line when it is loading
Screenshot 2025-09-19 at 5 42 26 PM

@amy-corson-ibigroup
Copy link
Contributor Author

This is awkward -- the line when it is loading Screenshot 2025-09-19 at 5 42 26 PM

What component is this?

@miles-grant-ibigroup
Copy link
Collaborator

This is awkward -- the line when it is loading Screenshot 2025-09-19 at 5 42 26 PM

What component is this?

Seeing this when clicking a route from the route viewer. As the pattern viewer is loading

Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thanks for dealing with all the back and forth here

Copy link
Contributor

@josh-willis-arcadis josh-willis-arcadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good!!

@amy-corson-ibigroup amy-corson-ibigroup merged commit 5fe3bba into dev Oct 13, 2025
9 checks passed
@amy-corson-ibigroup amy-corson-ibigroup deleted the remove-bg-pattern-viewer branch October 13, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants