-
Notifications
You must be signed in to change notification settings - Fork 59
Minor Pattern Viewer Overhaul #1467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is quite a good cleanup. Well implemented. Just a few small issues!
However, I would like to maybe ask for the old colored background mode to be configurable (even if off by default)? Just because on some configurations which have a whiter map the amount of white on the screen is pretty glaring, especially when the nearby view sidebar, the itinerary selection sidebar, and schedule view sidebar each have strong background colors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful! Thanks for dealing with all the back and forth here
josh-willis-arcadis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good!!


Description:
hideBackButtonprop (it didn't do anything)Also I removed the background color on the pattern viewer and changed the route color into more of an accent color. I also moved the operator and external link to the bottom of the page (in line with some previous designs) but I am open to feedback.
RouteRowDetailscomponent that can be used in the route viewer and pattern viewerPR Checklist: