Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PT] Fix aten::add decomposition for i4 weights #29511

Merged
merged 5 commits into from
Mar 18, 2025
Merged

[PT] Fix aten::add decomposition for i4 weights #29511

merged 5 commits into from
Mar 18, 2025

Conversation

rkazants
Copy link
Member

Details: Fix aten::add decomposition for i4 weights

Ticket: 164397

@rkazants rkazants requested a review from a team as a code owner March 17, 2025 13:38
@github-actions github-actions bot added the category: PyTorch FE OpenVINO PyTorch Frontend label Mar 17, 2025
@rkazants
Patch sub op
afcbaa7 
Signed-off-by: Kazantsev, Roman <[email protected]>
@ljaljushkin
Copy link
Contributor

@rkazants @mvafin @itikhono Are you considering implementing tests to cover these and similar issues (160006 ticket) on the OpenVINO side? This would help prevent the occurrence of such critical errors in the future.

@rkazants
Copy link
Member Author

@rkazants @mvafin @itikhono Are you considering implementing tests to cover these and similar issues (160006 ticket) on the OpenVINO side? This would help prevent the occurrence of such critical errors in the future.

Hi @ljaljushkin,
it was not covered by this commit from NNCF team: f1dc976

I think it will be better to cover by NNCF team who introduced this feature.

@rkazants rkazants requested review from a team as code owners March 17, 2025 19:00
@rkazants rkazants enabled auto-merge March 17, 2025 19:49
@rkazants rkazants added this to the 2025.2 milestone Mar 18, 2025
@rkazants rkazants mentioned this pull request Mar 18, 2025
Merged
@rkazants rkazants added this pull request to the merge queue Mar 18, 2025
Merged via the queue into openvinotoolkit:master with commit a9faa94 Mar 18, 2025
184 checks passed
@rkazants rkazants deleted the i4_weights_fix branch March 18, 2025 07:23
github-merge-queue bot pushed a commit that referenced this pull request Mar 18, 2025
@rkazants
[PT] Fix aten::add decomposition for i4 weights (#29525)
719af72 
**Details:** Fix aten::add decomposition for i4 weights

Cherry-pick of #29511

**Ticket:** 164397

---------

Signed-off-by: Kazantsev, Roman <[email protected]>
@johnrhimawan johnrhimawan mentioned this pull request Mar 23, 2025
Open
@wang-zhuoran wang-zhuoran mentioned this pull request Mar 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvafin mvafin mvafin approved these changes

@itikhono itikhono itikhono approved these changes

@mmikolajcz mmikolajcz Awaiting requested review from mmikolajcz mmikolajcz is a code owner automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

@PiotrKrzem PiotrKrzem Awaiting requested review from PiotrKrzem PiotrKrzem is a code owner automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

Assignees
No one assigned
Labels
category: PyTorch FE OpenVINO PyTorch Frontend
Projects
None yet
Milestone
2025.2
Development

Successfully merging this pull request may close these issues.
4 participants
@rkazants @ljaljushkin @mvafin @itikhono