Skip to content

[Snippets] Remove redundant ExtractConstants pass #32262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −90
Open

[Snippets] Remove redundant ExtractConstants pass #32262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02b2cca
[Snippets] Remove redundant ExtractConstants pass
aobolensk Oct 1, 2025
a689355
reuse helper
aobolensk Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/common/snippets/include/snippets/pass/common_optimizations.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ namespace ov::snippets::pass {
class CommonOptimizations : public ov::pass::MatcherPass {
class SubgraphPass;
class SubgraphManager;
friend class ExtractConstants;
friend class ExtractUnsupportedTransposes;
friend class SplitDimensionM;

Expand Down
30 changes: 0 additions & 30 deletions src/common/snippets/include/snippets/pass/extract_constants.hpp
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions src/common/snippets/src/pass/common_optimizations.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
#include "snippets/itt.hpp"
#include "snippets/op/subgraph.hpp"
#include "snippets/pass/explicit_transpose_matmul_inputs.hpp"
#include "snippets/pass/extract_constants.hpp"
#include "snippets/pass/extract_unsupported_transposes.hpp"
#include "snippets/pass/fq_decomposition.hpp"
#include "snippets/pass/softmax_reshape_elimination.hpp"
Expand Down Expand Up @@ -53,9 +52,6 @@ CommonOptimizations::CommonOptimizations(const CommonOptimizations::Config& conf
manager.run_passes(body);

ov::snippets::pass::CommonOptimizations::SubgraphManager subgraph_manager;
// At the moment only non-scalar Constants of FakeQuantize can be inside Subgraph
// so we can enable ExtractConstants pass for quantized models
REGISTER_SNIPPETS_PASS(subgraph_manager, ov::snippets::pass::ExtractConstants, is_quantized);
REGISTER_SNIPPETS_PASS(subgraph_manager, ov::snippets::pass::ExtractUnsupportedTransposes, is_domain_sensitive);
REGISTER_SNIPPETS_PASS(subgraph_manager,
ov::snippets::pass::SplitDimensionM,
Expand Down
51 changes: 0 additions & 51 deletions src/common/snippets/src/pass/extract_constants.cpp
View file
Open in desktop

This file was deleted.

7 changes: 3 additions & 4 deletions src/common/snippets/src/pass/validate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include "openvino/core/node_input.hpp"
#include "openvino/core/shape.hpp"
#include "openvino/core/type.hpp"
#include "openvino/op/broadcast.hpp"
#include "openvino/op/constant.hpp"
#include "openvino/op/convert.hpp"
#include "openvino/op/fake_quantize.hpp"
Expand All @@ -28,6 +27,7 @@
#include "snippets/itt.hpp"
#include "snippets/op/convert_saturation.hpp"
#include "snippets/op/convert_truncation.hpp"
#include "snippets/op/subgraph.hpp"
#include "snippets/pass/explicit_transpose_matmul_inputs.hpp"
#include "snippets/pass/fq_decomposition.hpp"
#include "snippets/utils/utils.hpp"
Expand All @@ -49,9 +49,8 @@ bool Validate::is_supported_constant(const std::shared_ptr<const ov::Node>& op)
const auto consumers = op->get_output_target_inputs(0);
return constant && (ov::shape_size(constant->get_output_shape(0)) == 1 ||
std::all_of(consumers.cbegin(), consumers.cend(), [](const ov::Input<ov::Node>& in) {
return ov::is_type_any_of<const ov::op::v1::Transpose,
const ov::op::v1::Broadcast,
const ov::op::v3::Broadcast>(in.get_node());
return ov::snippets::op::Subgraph::constant_input_should_be_inside_body(
in.get_node()->shared_from_this());
}));
}

Expand Down
Loading