Changes made to correctly handle non ASCII characters and avoid crashes #32280
+10
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was studying the issue #32110
This is my observation
This mismatch caused crashes if the path contained non-ASCII characters (e.g., Korean 새 폴더3).
And the changes I proposed
Originally, the code constructed the path like this:
With Unicode support → u8path correctly interprets the UTF-8 string.
Without Unicode support → fallback to locale-based constructor (keeps legacy behavior).
PLEASE REVIEW THIS PR AND DO LET ME KNOW IF THERE ARE ANY CHANGES REQUIRED
THANKS