-
Notifications
You must be signed in to change notification settings - Fork 71
feat(cli): add SegmentationArgs to prove command
#2178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds configurable segmentation parameters to the prove command in the CLI, allowing users to customize trace height and cell limits for proof generation. The default segmentation limits have also been reduced for more conservative resource usage.
Key changes:
- Reduced default segmentation limits (
DEFAULT_MAX_TRACE_HEIGHTfrom 2^23 to 2^22,DEFAULT_MAX_CELLSfrom 2B to 1.2B) - Added
SegmentationArgsstruct with CLI arguments forsegment_max_heightandsegment_max_cells - Integrated segmentation arguments into all three proof generation subcommands (App, Stark, Evm)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/vm/src/arch/execution_mode/metered/segment_ctx.rs | Reduced default segmentation limits for trace height and cells |
| crates/cli/src/commands/prove.rs | Added SegmentationArgs struct and integrated it into prove subcommands with helper functions |
| benchmarks/prove/src/util.rs | Updated comment to clarify segment_max_cells refers to total cells across all chips |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This comment has been minimized.
This comment has been minimized.
0884791 to
0aee951
Compare
Commit: 0aee951 |
No description provided.