-
Notifications
You must be signed in to change notification settings - Fork 190
fix: discoloured credentials on press due to touchable opacity #1668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: discoloured credentials on press due to touchable opacity #1668
Conversation
… miscolouring on pressed credentials Signed-off-by: Christian Lippa <christian.lippa@ontario.ca>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1668 +/- ##
=======================================
Coverage 53.68% 53.68%
=======================================
Files 303 303
Lines 10814 10816 +2
Branches 2924 2993 +69
=======================================
+ Hits 5805 5807 +2
+ Misses 4980 4960 -20
- Partials 29 49 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Christian Lippa <christian.lippa@ontario.ca>
|
|
@LippaC-OPS Can you get some screen shots of the before and after on the credential? |
bryce-mcmath
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep the same appearance and behaviour as the default, and just allow it to be customizable with DI? Also need before and after screen captures
|
|
@bryce-mcmath It seems the underlying issue is actually in the bundle overlay defaulting to a generated hex colour off of the credentialDefinitionId. So in my case here its defaulting to purple which when the credential is pressed its going from green to purple. Will have to look into another solution for this, maybe default to a more generic colour like black or grey? |
|
Closing after a Bifold community discussion. |



Summary of Changes
Change Touchable Opacity to Pressable with custom opacity to fix discolouring on pressed credentials.
When some credentials were being pressed the automatically applied opacity from the touchable opacity made them look discoloured (ie purple for green credentials)
Screenshots, videos, or gifs
Breaking change guide
N/A
Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this)If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓