Skip to content

Conversation

@LippaC-OPS
Copy link
Contributor

@LippaC-OPS LippaC-OPS commented Sep 26, 2025

Summary of Changes

Change Touchable Opacity to Pressable with custom opacity to fix discolouring on pressed credentials.

When some credentials were being pressed the automatically applied opacity from the touchable opacity made them look discoloured (ie purple for green credentials)

Screenshots, videos, or gifs

Breaking change guide

N/A

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this)
  • If applicable, screenshots, gifs, or video are included for UI changes
  • If applicable, breaking changes are described above along with how to address them
  • If applicable, added changeset(s)
  • Added sufficient tests so that overall code coverage is not reduced

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated checks have passed

… miscolouring on pressed credentials

Signed-off-by: Christian Lippa <christian.lippa@ontario.ca>
@LippaC-OPS LippaC-OPS requested a review from a team as a code owner September 26, 2025 18:22
@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2025

⚠️ No Changeset found

Latest commit: 1794be4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.68%. Comparing base (0a49f17) to head (1794be4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1668   +/-   ##
=======================================
  Coverage   53.68%   53.68%           
=======================================
  Files         303      303           
  Lines       10814    10816    +2     
  Branches     2924     2993   +69     
=======================================
+ Hits         5805     5807    +2     
+ Misses       4980     4960   -20     
- Partials       29       49   +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Christian Lippa <christian.lippa@ontario.ca>
@sonarqubecloud
Copy link

@LippaC-OPS LippaC-OPS changed the title fix: fix: discoloured credentials on press due to touchable opacity Sep 26, 2025
@al-rosenthal
Copy link
Contributor

@LippaC-OPS Can you get some screen shots of the before and after on the credential?

Copy link
Contributor

@bryce-mcmath bryce-mcmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the same appearance and behaviour as the default, and just allow it to be customizable with DI? Also need before and after screen captures

@jleach jleach marked this pull request as draft November 18, 2025 16:23
@sonarqubecloud
Copy link

@LippaC-OPS
Copy link
Contributor Author

@bryce-mcmath It seems the underlying issue is actually in the bundle overlay defaulting to a generated hex colour off of the credentialDefinitionId. So in my case here its defaulting to purple which when the credential is pressed its going from green to purple. Will have to look into another solution for this, maybe default to a more generic colour like black or grey?

@jleach
Copy link
Contributor

jleach commented Jan 13, 2026

Closing after a Bifold community discussion.

@jleach jleach closed this Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants