Skip to content

Conversation

@LippaC-OPS
Copy link
Contributor

@LippaC-OPS LippaC-OPS commented Jan 9, 2026

Summary of Changes

Add unacceptable PIN list to PIN validation rules to allow it to be injectable

Testing Instructions

Replace this text with detailed instructions on how to test the changes included in this PR.

Acceptance Criteria

Replace this text with the acceptance criteria that must be met for this PR to be approved.

Screenshots, videos, or gifs

Replace this text with embedded media for UI changes if they are included in this PR. If there are none, simply enter N/A

Breaking change guide

Replace this text with any breaking changes included in this PR along with how to address them in downstream projects. If there are none, simply enter N/A

Related Issues

Replace this text with issue #'s that are relevant to this PR. If there are none, simply enter N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this)
  • If applicable, screenshots, gifs, or video are included for UI changes
  • If applicable, breaking changes are described above along with how to address them
  • If applicable, added changeset(s)
  • Added sufficient tests so that overall code coverage is not reduced

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated checks have passed

@changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2026

🦋 Changeset detected

Latest commit: d2b0f4f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@bifold/core Patch
@bifold/remote-logs Patch
@bifold/oca Patch
@bifold/react-native-attestation Patch
@bifold/verifier Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Signed-off-by: LippaC-OPS <christian.lippa@ontario.ca>
@LippaC-OPS LippaC-OPS force-pushed the feat/injectable-unacceptable-pin-list branch from e04ad49 to 301473c Compare January 9, 2026 19:08
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.27%. Comparing base (630c530) to head (d2b0f4f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1747   +/-   ##
=======================================
  Coverage   52.27%   52.27%           
=======================================
  Files         320      320           
  Lines       11231    11231           
  Branches     3117     3200   +83     
=======================================
  Hits         5871     5871           
+ Misses       5314     5312    -2     
- Partials       46       48    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Christian Lippa <christian.lippa@ontario.ca>
@LippaC-OPS LippaC-OPS marked this pull request as ready for review January 12, 2026 13:57
@LippaC-OPS LippaC-OPS requested a review from a team as a code owner January 12, 2026 13:57
@sonarqubecloud
Copy link

@LippaC-OPS LippaC-OPS merged commit e718f5b into openwallet-foundation:main Jan 14, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants