IWDG_Enable() bug #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original condition to check if LSI is Ready (bit LSIRDY set to 1 by hardware in register RSTSCKR) in IWDG_Enable() can never be met, the updated condition works properly and allows for the program to continue execution after calling it
And mask disambiguation
|
I also noticed this bug when the compiler pointed me to it after I turned on |
kholia
pushed a commit
to kholia/ch32v003
that referenced
this pull request
Jul 11, 2024
Better way to handle Windows linking to the right libgcc.a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IWDG_Enable in ch32v00x_iwdg.c of the peripheral library has a bug while checking if the bit LSYRDY of the RSTSCKR register is set by waiting endlessly for it to be set with a condition impossible to meet:
while ((RCC->RSTSCKR)|(0x2)!= SET);The correct way should be:
while ((RCC->RSTSCKR & RCC_LSIRDY)!= RCC_LSIRDY);