Add in post for wdl 1.2.1 #19
Conversation
Updated the announcement date and improved clarity on various aspects of WDL 1.2.1, including file semantics, path resolution, function clarifications, example fixes, and testing infrastructure.
| This release includes clarifications, deprecations, bug fixes to examples, and improvements to the testing infrastructure: | ||
|
|
||
| * **File and Directory Semantics**: | ||
| * Clarify `File` and `Directory` path canonicalization, validation, and equality semantics. Clarify when `File`s and `Directories` must exist (at declaration evaluation time, not access time). Add `Directory` comparison operators to binary operators table. |
There was a problem hiding this comment.
It would be nice to link to the PRs that introduced these behaviors. You can see a full list of the PRs and issues here: https://github.com/openwdl/wdl/milestone/6?closed=1
|
|
||
| * **Path Resolution and Deprecations**: | ||
| * Clarified that relative paths in `File` and `Directory` declarations are resolved relative to the WDL document's parent directory outside the `output` section, and relative to the task's execution directory inside the `output` section. Also clarified that optional files evaluate to `None` in both contexts if the path does not exist. | ||
| * Deprecated the use of relative path literals in input and private variable declarations. |
There was a problem hiding this comment.
I think this conflicts with the item above where we clarified how relative paths behave (how could we deprecate it and also clarify its use?)
There was a problem hiding this comment.
Ya i need to remove this. We had removed it in an eralier PR and I didn't get rectify the conflict.
| * **Example Fixes**: | ||
| * Included fixes to examples introduced in v1.1.3. | ||
| * Fixed issues with examples that don't compile in wdl-tests thanks to [@adamnovak](https://github.com/adamnovak), [@stxue1](https://github.com/stxue1), [@claymcleod](https://github.com/claymcleod) and [@vsmalladi](https://github.com/vsmalladi): | ||
| * HISAT2 example uses unsupported `--sra-acc` option - fixed by updating to valid options. |
There was a problem hiding this comment.
Same here: if we have removed these examples, then these items about fixing HISAT2 and GATK are meaningless and should be removed too.
There was a problem hiding this comment.
Agreed. Artifact of doing this too early.
| categories: wdl bioinformatics workflows | ||
| --- | ||
|
|
||
| # Announcing WDL 1.2.1 |
There was a problem hiding this comment.
I would link to the appropriate milestone in both blog posts.
|
Personally, I prefer more prose-like blog posts categorizing all of the changes, explaining why they were made, and explaining what they mean to the user. Otherwise, they just read like a |
|
Ya I will make it more blog posty. I wanted to make sure content was mostly truthful and accurate since it has been a while since I wrote some of this and lots of things have been in flight. Will update this and |
Closes #25