Add some more cases where parentheses are needed in text output.#40
Merged
pstaabp merged 2 commits intoopenwebwork:mainfrom Oct 7, 2025
Merged
Add some more cases where parentheses are needed in text output.#40pstaabp merged 2 commits intoopenwebwork:mainfrom
pstaabp merged 2 commits intoopenwebwork:mainfrom
Conversation
Member
Author
|
I have not published to npm this yet. The version needs to be bumped before that is done. If there is sufficient demand for this, I can bump the version and publish to npm. In the mean time, testing will need to be done with the testing tools in this repository. |
somiaj
approved these changes
Oct 7, 2025
Contributor
somiaj
left a comment
somiaj
left a comment
There was a problem hiding this comment.
Fixes the issue. I think this might be worth a hot fix since it can affect correct answers in PG at the moment (though the cases are probably rare).
Fractions need parentheses around the numerator or denominator if anything is after a factorial or a SupSub. For example, 2/(3!4!) or 2/(2^2 3^2). SupSubs need parentheses on the superscripts or subscripts if anything is after a factorial. For example, 2^(2!3!) Also, a live fraction should be allowed to be typed after a factorial. For example, if 2! is typed and then the forward slash is typed it should result in the fraction with 2! in the numerator and the cursor in the denominator. Currenlty the 2! is in front of the fraction and the cursor is in the numerator. This fixes openwebwork/webwork2#2821.
drgrice1
force-pushed
the
parentheses-issues
branch
from
fedd038 to
f5b14c5
Compare
drgrice1
added a commit
to drgrice1/pg
that referenced
this pull request
Oct 7, 2025
openwebwork/mathquill#39 and openwebwork/mathquill#40 have been merged and a new version of @openwebwork/mathquill have been merged. This updates to the newly published version that includes those fixes.
drgrice1
added a commit
to drgrice1/pg
that referenced
this pull request
Oct 7, 2025
openwebwork/mathquill#39 and openwebwork/mathquill#40 have been merged and a new version of @openwebwork/mathquill have been merged. This updates to the newly published version that includes those fixes.
This was referenced Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fractions need parentheses around the numerator or denominator if anything is after a factorial or a SupSub. For example, 2/(3!4!) or 2/(2^2 3^2).
SupSubs need parentheses on the superscripts or subscripts if anything is after a factorial. For example, 2^(2!3!)
Also, a live fraction should be allowed to be typed after a factorial. For example, if 2! is typed and then the forward slash is typed it should result in the fraction with 2! in the numerator and the cursor in the denominator. Currenlty the 2! is in front of the fraction and the cursor is in the numerator.
This fixes openwebwork/webwork2#2821.