Speed up class list importing. #2713
Open
+29
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested the reloading of the large classlist you provided and skipped 5000 users. The dialog box is many pages worth. I was thinking that shortening the list if over 100 skipped user would be nice, but then again this is an extreme example and may not be worth the work. |
Use a batch insertion and update for users, permissions, and passwords when importing a class list. This improves the speed of imporing large class lists quite a bit. For example, importing a classlist containing 5000 users improves from around 22 seconds to around 7 seconds in my testing.
drgrice1
force-pushed
the
classlist-import-speed-up
branch
from
6769d39 to
16a6de3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a batch insertion and update for users, permissions, and passwords when importing a class list.
This improves the speed of imporing large class lists quite a bit. For example, importing a classlist containing 5000 users improves from around 22 seconds to around 7 seconds in my testing.