[Fix] Send background VPN errors and recovery as generic_message noti… #1147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesifier
reviewed
Oct 23, 2025
nemesifier
reviewed
Oct 24, 2025
There was a problem hiding this comment.
@stktyagi I cherry-picked your last commit to fix the CI build on top of master, can you please rebase on master and remove that commit from this branch?
Fixed all failing tests that were failing due to inconsistencies with recent updates in notification handling, logging, and retry mechanisms. Fixes #1049
stktyagi
force-pushed
the
issues/1049-send-generic-message
branch
from
624eb0c to
9f31948
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fications #1049
Modified tasks and tasks zerotier consistently with utils. Tested via manual testing.
Fixes #1049
Checklist
Reference to Existing Issue
Closes #1049
Description of Changes
Extended config/utils.py for sending api tasks' notification with fixing trigger_vpn_server_endpoint to send generic message notification for error and recovery.