Draft: [notifications] Respect Django permissions for notification preferences #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Staff users with the change_notification_settings permission can now view and modify notification preferences according to their organization membership. Superusers retain full access, and regular users can only modify their own settings. Fixes openwisp#312
panagiotisevaggelou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds permission checks for viewing and editing notification preferences, both in the API and in the admin interface.
Checklist
Reference to Existing Issue
Closes #312
Description of Changes
PreferencesPermissioninapi/permissions.pyandtest_funcinviews.pyto apply proper access rules.can_change_notificationsto control when the “Notification Preferences” button is shown.Notes
See my comment on the issue for more details.
This is a Draft PR and I would like some feedback, so I know I am on the right path.
Screenshot