Add sharding rule for stablehlo.batch_norm_inference op #847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Added sharding rule for stablehlo.batch_norm_inference op.
Intent: allow feature-axis sharding and pass it through between input, BN params {scale, offset, mean, var}, and output.
Rationale: BN params are feature-wise and broadcast over other axes.
Limits: ranked shapes; valid feature_index; params broadcastable on feature;no sharding of params on non-feature axes.
Signed-off-by: Sungjoon Shon <[email protected]>
sshonTT
force-pushed
the
sshon/batchnorm-sharding-rule
branch
from
46a89e2 to
161955b
Compare
Author
|
@tomnatan30 To fix this issue, I have updated a PR. Any comments / reviews would be appreciated! |
Author
|
@ZixuanJiang Hi! Apologies if I’m pinging the wrong person, but could you please take a look at this PR? This is my first contribution, so any feedback or comments would be greatly appreciated. |
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 9, 2026
The original PR is #847, whose author is https://github.com/sshonTT. PiperOrigin-RevId: 853974950
Collaborator
|
Thank you, Sungjoon. I added #954 and expect to submit it soon. |
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 9, 2026
The original PR is #847, whose author is https://github.com/sshonTT. PiperOrigin-RevId: 853974950
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 9, 2026
The original PR is #847, whose author is https://github.com/sshonTT. PiperOrigin-RevId: 854208861
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sharding rule for stablehlo.batch_norm_inference op.
Intent: allow feature-axis sharding and pass it through between input, BN params {scale, offset, mean, var}, and output. Rationale: BN params are feature-wise and broadcast over other axes.
Limits: ranked shapes; valid feature_index; params broadcastable on feature;no sharding of params on non-feature axes.