Skip to content

rm unused function insertSeenValue #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nsmithtt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

rm unused function insertSeenValue #934

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions shardy/dialect/sdy/transforms/propagation/debugging/source_sharding.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,35 +335,6 @@ void saveShardingOriginsOnModule(
}
}

// In the case where we have a Value used multiple times as an operand, we
// should only add the edge once. For example:
// ```mlir
// %0 = stablehlo.add %arg0, %arg0 <[<@mesh, [{"a", ?}]>]> : tensor<8xf32>
// return %0 : tensor<8xf32>
// ```
// The sharding projection said that both operand 0 and 1 are updated. However,
// they are the same value, so we only need to add the edge once. This is only
// the case for the target of the edge, because if the source appears multiple
// times, then it's because it effects multiple other operands/results in the
// op.
bool insertSeenValue(Operation* op, const PropagationEdge& edge,
llvm::SmallDenseSet<Value>& seenValues) {
EdgeNode target = edge.target;
switch (target.type) {
case EdgeNodeType::OPERAND: {
if (auto funcOp = dyn_cast<func::FuncOp>(op)) {
return seenValues
.insert(getBodyTerminator(funcOp)->getOperand(target.index))
.second;
}
return seenValues.insert(op->getOperand(target.index)).second;
}
case EdgeNodeType::RESULT: {
return true;
}
}
}

PropagationEdgesAttr createPropagationEdges(Operation* op,
const AxisToEdgesMap& axisToEdges,
MLIRContext* context) {
Expand Down