Add fh_to_parent export definition #18099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
approved these changes
Jan 5, 2026
Contributor
behlendorf
left a comment
behlendorf
left a comment
There was a problem hiding this comment.
Nice. Thanks for adding this support.
Contributor
Author
|
Ameer sent me a private message about a potential issue here. Let's hold off on merge for a few days till I ack back here post-investigation. |
behlendorf
added
Status: Work in Progress
anodos325
force-pushed
the
add-fh_to_parent-master
branch
from
114b8ca to
c3e8d57
Compare
ixhamza
approved these changes
Jan 7, 2026
behlendorf
approved these changes
Jan 8, 2026
Contributor
behlendorf
left a comment
behlendorf
left a comment
There was a problem hiding this comment.
This still looks good. If you could just confirm you guys are happy with the latest version we can merge it.
Contributor
Author
|
Yes. This is correct now as confirmed by Ameer as well via approval. |
amotin
added
Status: Work in Progress
Member
|
One more small change is coming. |
This commit adds support for converting a file handle to its parent dentry. This is called in exportfs_decode_fh_raw() when subtree checking is enabled in NFS. Defining this and handling the expanded filehandles allows the knfsd to succeed in handling the file handle where it might otherwise fail with ESTALE when trying to open by filehandle. A side effect of this change is that name_to_handle_at(2) and open_by_handle_at(2) now support AT_HANDLE_CONNECTABLE. Signed-off-by: Andrew Walker <[email protected]>
anodos325
force-pushed
the
add-fh_to_parent-master
branch
from
c3e8d57 to
dedd939
Compare
amotin
approved these changes
Jan 8, 2026
amotin
added
Status: Accepted
behlendorf
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for converting a file handle to its parent dentry. This is called in exportfs_decode_fh_raw() when subtree checking is enabled in NFS. Defining this and handling the expanded filehandles allows the knfsd to succeed in handling the file handle where it might otherwise fail with ESTALE when trying to open by filehandle.
A side effect of this change is that name_to_handle_at(2) and open_by_handle_at(2) now support AT_HANDLE_CONNECTABLE, which was introduced in kernel 6.13.