Set custom default value for content-header-bytes-length#114
Merged
Conversation
override default content-header-bytes-length to accomodate more sites we do not want to expose this setting which is too complex + we do not want to change warc2zim default which is still the best comprise value, when you have someone knowledgeable using the tool
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
- Coverage 46.11% 45.99% -0.12%
==========================================
Files 10 10
Lines 386 387 +1
Branches 44 44
==========================================
Hits 178 178
- Misses 206 207 +1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
rgaudin
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have regular occurrences of zimit failures due to the charset encoding being too far at the beginning of the HTML document. By default, we expect it to be in the first 1024 bytes. This is a sensible default because recommendations are that this should be at the beginning of the HTML head. Not all sites follow this convention, and many are far from that.
I propose to override default content-header-bytes-length only on zimit-frontend to accommodate more sites for non-knowledgeable persons.
We do not want to expose this setting on zimit.kiwix.org because it is too complex.
We should not change warc2zim default (1024) which is still the best comprise value, when you have someone knowledgeable using the tool, because it avoid spending too much resources on this.
WDYT?