Fix MarkUnsafe missing Spec in ansible operator

[gaelgatelement]

Description of the change:
Closes #5160

Motivation for the change:
MarkUnsafe was missing some properties.

[gaelgatelement]

I rebased the MR, in case you want to approve it.

[gaelgatelement]

Hello,

I'm sorry to ask, but could this MR be looked at please ? Its rather simple and is probably fast to review.

[everettraven]

@gaelgatelement Thanks for this contribution! I apologize that the PR got lost in the weeds.

I have one question:

[everettraven]

Going to close and reopen to rerun CI

[varshaprasad96]

@gaelgatelement Just looked into the issue and seems like it was created long back in 2021. I remember on having a PR that marked the spec as unsafe if specified so in watches.yaml. Looks like it happens here: https://github.com/varshaprasad96/operator-sdk/blob/c247d4b4142cd7736f122796e3388fbd05f62b71/internal/ansible/runner/runner.go#L352-L354C4

where the parameters created from the spec are recursively marked unsafe. Just wondering if there was something missing even after that.

[gaelgatelement]

@gaelgatelement Just looked into the issue and seems like it was created long back in 2021. I remember on having a PR that marked the spec as unsafe if specified so in watches.yaml. Looks like it happens here: https://github.com/varshaprasad96/operator-sdk/blob/c247d4b4142cd7736f122796e3388fbd05f62b71/internal/ansible/runner/runner.go#L352-L354C4

where the parameters created from the spec are recursively marked unsafe. Just wondering if there was something missing even after that.

Indeed, this PR is a small fix to your feature. It seems the spec is not recursively marked as unsafe before the change I implemented here.

EDIT : So i'm re-reading the code here, and I think mark unsafe was missing the magic _spec variable. Ansible tries to parse the content using jinja templating since its not marked as unsafe.

[gaelgatelement]

Sorry for the ping, but because I edited my message, I'm not sure you received a notification.

[everettraven]

After the discussion that has gone on and looking back at the referenced issue I think its reasonable for this change to come in. If we end up marking all the fields as unsafe anyways we might as well mark the spec unsafe also.

Thanks @gaelgatelement !

/lgtm

[varshaprasad96]

EDIT : So i'm re-reading the code here, and I think mark unsafe was missing the magic _spec variable. Ansible tries to parse the content using jinja templating since its not marked as unsafe.

Got it! Thanks for fixing it @gaelgatelement!

[varshaprasad96]

/lgtm
/approve