Refactor server by merging the initial and hackathon ones #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeArchiTek
changed the title
dgarros
approved these changes
Jul 31, 2025
| ERROR = "error" | ||
|
|
||
|
|
||
| class MCPResponse[T](BaseModel): |
There was a problem hiding this comment.
It looks good but it feels like it should be provided by FastMCP, I think it would be good to start a discussion on their repo to see if
- they would accept this contribution
- there is another way to achieve the same
There was a problem hiding this comment.
From my understanding, there is already some part ongoing and should be available soon (some got merged last week)
|
|
||
|
|
||
| mcp = FastMCP("Infrahub MCP", lifespan=app_lifespan) | ||
| mcp: FastMCP = FastMCP(name="Infrahub MCP Server", version="0.1.0", lifespan=app_lifespan) |
There was a problem hiding this comment.
we could read the version dynamically to make sure it's always accurate
src/infrahub_mcp_server/branch.py
Outdated
| mcp: FastMCP = FastMCP(name="Infrahub Branches") | ||
|
|
||
|
|
||
| @mcp.tool(tags=["branches", "create"]) |
There was a problem hiding this comment.
I'm curious, what is the impact of having the tags, how are they influencing the LLM ?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.