[FSSDK-10265] fix: UPS Lookup & Save during batched Decide
#374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want this reference PR to be clear about what needs changing.
_decisionBatchInProgress from true to false
I'm hitting `Lookup` thrice for some reason in DecideAllWithUspShouldOnlyLookupSaveOnce
This reverts commit dfe1367.
mikechu-optimizely
changed the title
Lookup & Save during batched Decide
jaeopt
requested changes
Oct 14, 2024
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
It looks good!
I have a couple of suggestions for legacy API support and testing.
| userProfileServiceMock.Verify(l => l.Save(It.IsAny<Dictionary<string, object>>()), | ||
| Times.Once); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
These tests look good. Wondering if we have tests covering the contents of the final UPS save call, combining all decisions in the session.
Contributor
There was a problem hiding this comment.
Can we also have the similar coverage (lookup once - save once, the ups save contents) with legacy APIs (activate, getVariation) for regression?
Contributor
Author
There was a problem hiding this comment.
Added coverage of the final UPS Save as requested.
I'm researching the Activate and GetVariation tests where UPS is used.
Co-authored-by: Jae Kim <[email protected]>
jaeopt
reviewed
Oct 14, 2024
…h-decide' into mike/FSSDK-10265-ups-during-batch-decide
I need more time to fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
LookupandSaveonce when usingDecideAllandDecideForKeys.Test plan
Issues