Skip to content

[FSSDK-11528] Holdout support in decision service #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 29, 2025
Merged

[FSSDK-11528] Holdout support in decision service #1075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6412e89
decision service holdout implementation
junaed-optimizely Jul 24, 2025
3a90a81
[FSSDK-11528] audience condition improvement
junaed-optimizely Jul 25, 2025
f6c4cda
[FSSDK-11528] decision service tests added
junaed-optimizely Jul 25, 2025
9a77240
[FSSDK-11528] decision service tests improvement
junaed-optimizely Jul 25, 2025
b8eac89
[FSSDK-11528] test improvement + decision service logic adjustment
junaed-optimizely Jul 28, 2025
4c88648
[FSSDK-11528] feature toggle readibility improvement
junaed-optimizely Jul 28, 2025
aa3381e
[FSSDK-11528] type def update
junaed-optimizely Jul 28, 2025
0d034b2
[FSSDK-11528] test improvement
junaed-optimizely Jul 28, 2025
78eaa41
[FSSDK-11528] remove only
junaed-optimizely Jul 28, 2025
de3baaa
[FSSDK-11529] condition adjustment
junaed-optimizely Jul 29, 2025
8e33597
Revert "[FSSDK-11529] condition adjustment"
junaed-optimizely Jul 29, 2025
56fd283
[FSSDK-11528] review update
junaed-optimizely Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/core/bucketer/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ export const bucket = function(bucketerParams: BucketerParams): DecisionResponse
const decideReasons: DecisionReason[] = [];
// Check if user is in a random group; if so, check if user is bucketed into a specific experiment
const experiment = bucketerParams.experimentIdMap[bucketerParams.experimentId];
const groupId = experiment['groupId'];
// Optional chaining skips groupId check for holdout experiments; Holdout experimentId is not in experimentIdMap
const groupId = experiment?.['groupId'];
if (groupId) {
const group = bucketerParams.groupIdMap[groupId];
if (!group) {
Expand Down
Loading
Loading