[FSSDK-11167] Implement CMAB service #367
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alue structs (otherwise breaks in ruby version change)
Mat001
approved these changes
Jul 16, 2025
| @@ -0,0 +1,153 @@ | |||
| # frozen_string_literal: true | |||
| CmabDecision.new(variation_id: variation_id, cmab_uuid: cmab_uuid) | ||
| end | ||
|
|
||
| def filter_attributes(project_config, user_context, rule_id) |
There was a problem hiding this comment.
python-sdk uses this as a private method. Do yuo want to use privates here too?
Same for
def get_cache_key(user_id, rule_id)
def hash_attributes(attributes)
ruby has stricter private method enforcement, can't call from outside. Not sure it's 100% necessary, think about it, see if using private methods would break any access from other parts..
There was a problem hiding this comment.
If private, you'd need to update test calls to use send() for private methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DefaultCmabService implemented to support cmab experiments.
Test plan
Unit tests added.
Issues
FSSDK-11167