Skip to content

Refactor infra discovery script to align with WDT discover.py and remove Internal WDT dependencies #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mahuwa-Barman merged 7 commits into from
Dec 15, 2025
Merged

Refactor infra discovery script to align with WDT discover.py and remove Internal WDT dependencies #97

Mahuwa-Barman merged 7 commits into from
Dec 15, 2025

Conversation

@Mahuwa-Barman
Copy link
Contributor

@Mahuwa-Barman Mahuwa-Barman commented Dec 10, 2025 •
edited
Loading

https://jira.oraclecorp.com/jira/browse/JCS-15086

Tested with JRF, Non-JRF and Secure mode domains with multiple nodes.

@oracle-contributor-agreement
Copy link

oracle-contributor-agreement bot commented Dec 10, 2025

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Dec 10, 2025
@Mahuwa-Barman Mahuwa-Barman changed the base branch from main to topic-oci-weblogic-migration_wdt_refactor December 10, 2025 13:27
@Mahuwa-Barman Mahuwa-Barman changed the base branch from topic-oci-weblogic-migration_wdt_refactor to development December 10, 2025 13:31
@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Dec 10, 2025
@Mahuwa-Barman Mahuwa-Barman changed the base branch from development to topic-oci-weblogic-migration_wdt_refactor December 10, 2025 13:35
@oracle-contributor-agreement
Copy link

oracle-contributor-agreement bot commented Dec 10, 2025

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. and removed OCA Verified All contributors have signed the Oracle Contributor Agreement. labels Dec 10, 2025
@Mahuwa-Barman Mahuwa-Barman changed the base branch from topic-oci-weblogic-migration_wdt_refactor to topic-oci-weblogic-migration_wdt_int_dependencies_removal December 10, 2025 14:43
@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Dec 10, 2025
@Mahuwa-Barman Mahuwa-Barman requested a review from telake December 10, 2025 14:43
@Mahuwa-Barman Mahuwa-Barman mentioned this pull request Dec 10, 2025
Merged
telake
telake reviewed Dec 15, 2025
View reviewed changes
lib/python/patch_discover_infra_model.py Outdated
full_cmd = base_cmd + [target, cmd]

if SSH_PASSWORD:
full_cmd = ["sshpass", "-p", SSH_PASSWORD] + full_cmd
Copy link
Member

@telake telake Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be preferable to pass secrets as stdin. https://security.stackexchange.com/questions/190071/when-running-shell-scripts-is-it-safer-to-pass-sensitive-information-using-stdi has a good explanation for why.

Copy link
Contributor Author

@Mahuwa-Barman Mahuwa-Barman Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated it.

telake
telake reviewed Dec 15, 2025
View reviewed changes
telake
telake approved these changes Dec 15, 2025
View reviewed changes
Copy link
Member

@telake telake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with file now used instead of pwd as argument.

@Mahuwa-Barman Mahuwa-Barman merged commit a222d13 into topic-oci-weblogic-migration_wdt_int_dependencies_removal Dec 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@telake telake telake approved these changes

Assignees

No one assigned

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mahuwa-Barman @telake