refactor: SonarCloud suggestions

oracle · Dec 2, 2024 · cdaa37a · cdaa37a
1 parent 327df4c
commit cdaa37a
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 14 deletions.
diff --git a/ocd/packages/desktop/index.html b/ocd/packages/desktop/index.html
@@ -1,12 +1,11 @@
 <!DOCTYPE html>
-<html>
+<html lang="en">
   <head>
     <meta charset="UTF-8" />
     <title>OKIT - Open Cloud Designer</title>
   </head>
   <body>
     <div id="root"></div>
     <script type="module" src="/src/main.tsx"></script>
-    <!-- <script type="module" src="/src/renderer.ts"></script> -->
   </body>
 </html>
diff --git a/ocd/packages/react/src/components/OcdCanvasLayers.tsx b/ocd/packages/react/src/components/OcdCanvasLayers.tsx
@@ -81,9 +81,7 @@ const OcdCanvasLayer = ({ ocdDocument, setOcdDocument, layer } : LayerBarLayerPr
             <div className={`ocd-canvas-layer-name ${layer.class}`} onClick={() => onLayerSelectedClick()} aria-hidden>
                 <input id={layer.id.replace(/\W+/g, "")} type='text' value={title} onChange={onChange} tabIndex={-1}></input>
             </div>
-            {page.layers.length > 1 && <div className={`ocd-layer-visiblity-icon delete-layer`}
-                onClick={onDeleteClick}
-            ></div>}
+            {page.layers.length > 1 && <div className={`ocd-layer-visiblity-icon delete-layer`} onClick={onDeleteClick} aria-hidden></div>}
         </div>
     )
 }

diff --git a/ocd/packages/react/src/components/OcdCanvasPages.tsx b/ocd/packages/react/src/components/OcdCanvasPages.tsx
@@ -114,7 +114,7 @@ const OcdPagesThreeDotMenu = ({ocdDocument, setOcdDocument}: PageBarMenuProps):
                         <li className='ocd-dropdown-menu-item ocd-mouseover-highlight'><div><label><input id='ocd_console_page_display_grid' type='checkbox' onChange={displayGridOnChange} ref={cbRef} checked={activePage.grid}/>Display Grid</label></div></li>
                         <li className='ocd-dropdown-menu-item'><div>--------------------------------</div></li>
                         <li className='ocd-dropdown-menu-item ocd-mouseover-highlight'><div onClick={onDuplicatePageClick} aria-hidden>Duplicate "{activePageName}"</div></li>
-                        {ocdDocument.design.view.pages.length > 1 && <li className='ocd-dropdown-menu-item ocd-mouseover-highlight'><div onClick={onDeletePageClick}>Delete "{activePageName}"</div></li>}
+                        {ocdDocument.design.view.pages.length > 1 && <li className='ocd-dropdown-menu-item ocd-mouseover-highlight'><div onClick={onDeletePageClick} aria-hidden>Delete "{activePageName}"</div></li>}
                         <li className='ocd-dropdown-menu-item ocd-mouseover-highlight'><div onClick={onAddPageClick} aria-hidden>Add Page</div></li>
                     </ul>
                 </li>

diff --git a/ocd/packages/react/src/components/OcdPalette.tsx b/ocd/packages/react/src/components/OcdPalette.tsx
@@ -19,8 +19,8 @@ const OcdPalette = ({ ocdConsoleConfig, setDragData, ocdDocument }: PaletteProps
     return (
         <div className='ocd-designer-left-panel'>
             <div className={`ocd-designer-tab-bar ocd-designer-tab-bar-theme`}>
-                <div className={`ocd-designer-tab ocd-designer-tab-theme ${activeTab === 'provider' ? 'ocd-designer-active-tab-theme' : ''}`} onClick={() => onTabClick('Provider')}><span>Provider</span></div>
-                <div className={`ocd-designer-tab ocd-designer-tab-theme ${activeTab === 'model' ? 'ocd-designer-active-tab-theme' : ''}`} onClick={() => onTabClick('Model')}><span>Model</span></div>
+                <div className={`ocd-designer-tab ocd-designer-tab-theme ${activeTab === 'provider' ? 'ocd-designer-active-tab-theme' : ''}`} onClick={() => onTabClick('Provider')} aria-hidden><span>Provider</span></div>
+                <div className={`ocd-designer-tab ocd-designer-tab-theme ${activeTab === 'model' ? 'ocd-designer-active-tab-theme' : ''}`} onClick={() => onTabClick('Model')} aria-hidden><span>Model</span></div>
             </div>
             <ActiveTab
                 ocdConsoleConfig={ocdConsoleConfig} 

diff --git a/ocd/packages/react/src/components/OcdProperties.tsx b/ocd/packages/react/src/components/OcdProperties.tsx
@@ -52,7 +52,7 @@ const OcdPropertiesTabbar = ({modelId, coordsId, activeTab, setActiveTab, additi
 const OcdPropertiesTabbarTab = ({title, active, setActive, additionalCss}: {title: string, active: boolean, setActive: (title: string) => void, additionalCss: string}): JSX.Element => {
     console.debug('OcdPropertiesTabbarTab: Render', title, active ? '- Active' : '')
     return(
-        <div className={`ocd-designer-tab ocd-designer-tab-theme ${active ? 'ocd-designer-active-tab-theme' : ''} ${additionalCss ? additionalCss : ''}`} onClick={() => setActive(title.toLowerCase())}><span>{title}</span></div>
+        <div className={`ocd-designer-tab ocd-designer-tab-theme ${active ? 'ocd-designer-active-tab-theme' : ''} ${additionalCss ? additionalCss : ''}`} onClick={() => setActive(title.toLowerCase())} aria-hidden><span>{title}</span></div>
     )
 }
 
@@ -218,15 +218,15 @@ const OcdResourceTags = ({ocdDocument, setOcdDocument}: DesignerResourceProperti
         const tag = freeformTags.find((t) => t.key === oldKey)
         if (tag) {
             tag.key = newKey
-            setFreeformTags(freeformTags)
+            setFreeformTags([...freeformTags])
             updateFreeformTags(freeformTags)
         }
     })
     const onFreeformValueChange = ((key: string, value: string) => {
         const tag = freeformTags.find((t) => t.key === key)
         if (tag) {
             tag.value = value
-            setFreeformTags(freeformTags)
+            setFreeformTags([...freeformTags])
             updateFreeformTags(freeformTags)
         }
     })
@@ -245,23 +245,23 @@ const OcdResourceTags = ({ocdDocument, setOcdDocument}: DesignerResourceProperti
         const tag = definedTags.find((t) => t.namespace === oldNamespace && t.key === key)
         if (tag) {
             tag.namespace = newNamespace
-            setDefinedTags(definedTags)
+            setDefinedTags([...definedTags])
             updateDefinedTags(definedTags)
         }
     })
     const onDefinedKeyChange = ((namespace: string, oldKey: string, newKey: string) => {
         const tag = definedTags.find((t) => t.namespace === namespace && t.key === oldKey)
         if (tag) {
             tag.key = newKey
-            setDefinedTags(definedTags)
+            setDefinedTags([...definedTags])
             updateDefinedTags(definedTags)
         }
     })
     const onDefinedValueChange = ((namespace: string, key: string, value: string) => {
         const tag = definedTags.find((t) => t.namespace === namespace && t.key === key)
         if (tag) {
             tag.value = value
-            setDefinedTags(definedTags)
+            setDefinedTags([...definedTags])
             updateDefinedTags(definedTags)
         }
     })