Fix Range#cover? on begin-less ranges and non-integer values.
#3810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, we need this method to work when passed `nil`, which we've observed code in the wild doing. Co-authored-by: Randy Stauner <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
nirvdrum
added
bug
shopify
and removed
OCA Verified
andrykonchin
approved these changes
Mar 7, 2025
andrykonchin
added
the
in-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, we need this method to work when passed
nil, which we've observed occurring in the frozen_record gem.