Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one was pretty weird.
My specific qualm and the reason for doing this is that being able to accurately lex single-quoted strings in OCaml would be kind of a nightmare. You very frequently have type annotations like
'aand match on things calleda'. As far as I can tell, there's not a fantastic way to handle both of those things and still come out with something that isn't nightmarish in its complexity--so IMO, the best way to do it is to just completely nuke that.I also added
listas a type. There's definitely a lot more types that could be added, but I thinklistis probably pervasive enough to be the absolute bare minimum.It's been a while since I've written one of these; let me know if I made any silly mistakes.