Refresh Bitcoin Core RPC client on authentication failure#4452
Open
RobertClarke wants to merge 1 commit into
Open
Refresh Bitcoin Core RPC client on authentication failure#4452RobertClarke wants to merge 1 commit into
RobertClarke wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Bitcoin Core restarts, it regenerates the
.cookiefile with new credentials. Previously,ordwould fail with 401 errors until restarted.This is particularly useful when running
ord serverlong-term while occasionally restarting Bitcoin Core for configuration changes (peer adjustments, network tuning, etc.). With this change,ordautomatically recovers without manual intervention.Changes:
Index.clientinRwLockto allow runtime credential refreshwith_retry()wrapper that detects 401 errors and re-reads the cookie fileFetcherused during indexing