Return error when exporting addresses without address index#4494
Open
Bortlesboat wants to merge 1 commit into
Open
Return error when exporting addresses without address index#4494Bortlesboat wants to merge 1 commit into
Bortlesboat wants to merge 1 commit into
Conversation
When --include-addresses is used but the address index was not built, the export falls back to fetching every transaction via RPC which is prohibitively slow. Return a clear error instead and remove the slow RPC fallback path. Fixes ordinals#3917
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
--include-addressesis used but the index was not built with--index-addresses, export falls back to fetching every transactionvia RPC, which is prohibitively slow.
Return a clear error instead and remove the RPC fallback path.
Fixes #3917