Feature/renderoceans

[durankeeley]

Render Oceans and overlay when there or islands or inlets with roads so they not rendered with water (coastlines can not outline them)

[originalankur]

Thanks @durankeeley will review during upcoming weekend and get back.

[D3SX]

Hi, I have this problem for Hong-Kong and your PR does not fix the issue for this city. It works for other countries, but not this one.
Thanks

[durankeeley]

@D3SX my latest commit should work

[D3SX]

@D3SX my latest commit should work

It does, thanks a lot !

[LouvAndTech]

Hello,

I tried implementing your PR and got interesting results for the Island of Texel in the Netherlands while using the --include-oceans option, could that be caused by the fact this island is partially under the sea level ?

It's not really a problem since using you PR without the option gives a really nice result, but I thought I would let you know.

[jimmyhartington]

I have tried this for Copenhagen to fix the ocean from the original and it helps. But it still does not render all the ocean/water ways correctly.

[LouvAndTech]

@jimmyhartington I had the a similar problem with Gouda where some water element would be hidden behind land, the fix for me was to edit the Z-Order to make sure that 'parks' (or other elements) would be displayed behind any body of water.
I don't know if your issue come from there but that may be easy to test.

[jimmyhartington]

@jimmyhartington I had the a similar problem with Gouda where some water element would be hidden behind land, the fix for me was to edit the Z-Order to make sure that 'parks' (or other elements) would be displayed behind any body of water. I don't know if your issue come from there but that may be easy to test.

I can try that. But I am a bit unsure, where I define this?

[LouvAndTech]

I can try that. But I am a bit unsure, where I define this?

You're looking for the lines :

parks_polys.plot(ax=ax, facecolor=THEME['parks'], edgecolor='none', zorder=0.8)

and

water_polys.plot(ax=ax, facecolor=THEME['water'], edgecolor='none', zorder=0.5)

In the original script. If I'm not mistaken you can basically try to invert the two zorder.