Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(manager): register user with email #37

Merged
merged 78 commits into from
Dec 31, 2023
Merged

feat(manager): register user with email #37

merged 78 commits into from
Dec 31, 2023

Conversation

abtinokhovat
Copy link
Contributor

@abtinokhovat abtinokhovat commented Dec 14, 2023 •
edited
Loading

  • implementing JWT
  • implementing login and register
    • handler
    • validator
    • service
  • adding richerror

sinaw369 and others added 27 commits December 12, 2023 20:00
@sinaw369
regster email with jwt
f4f9e36
@sinaw369
fix some issue
ef4ecdc
@sinaw369
Merge branch 'ormushq:main' into registerEmail
dffda8e
@sinaw369
add Repository interface
0109ff3
@sinaw369
Merge branch 'registerEmail' of https://github.com/sinaw369/ormus int…
933b7c7 
…o registerEmail
@abtinokhovat
refactor(manager): fix some typos and fixed some naming conventions
54662e1
@abtinokhovat
chore: add testify library
bcbb6e5
@abtinokhovat
refactor(manager): renamed service file to jwt and refactored some na…
5ce1b05 
…mes, added some config
@abtinokhovat
feat(manager): add config for jwt
c9c5d0e
@abtinokhovat
refactor(manager): rename some structs and packages and adding some q…
37d84d3 
…uestions as TODOs
@abtinokhovat
fix(manager): fix JWT configuration problems
7c0ccf4
@abtinokhovat
refactor(ormus): replace "." with delimiter in config package
fa2f874
@abtinokhovat
refactor(manager): refactor error naming
cfb9e41
@abtinokhovat
test(manager): add jwt module tests
5331419
@abtinokhovat
refactor(manager): move auth service to the folder
b2fea63
@abtinokhovat
refactor(manager): add error constant for login
db52ced
@sinaw369
add hash function for password
d9f13e1
@sinaw369
add richerror
3a3af2d
@sinaw369
hash register password
ce76c67
@abtinokhovat
refactor(ormus): fix some naming typos
fd30d1e
@abtinokhovat
test(manager): fix test failing with rich error
631a48a
@abtinokhovat
test(ormus): add tests for password package
4660cf8
@abtinokhovat
reformat(ormus): rename error variable names
18e17c0
@abtinokhovat
refactor(ormus): refactor auth service names and added repository dep…
c078668 
…endency
@abtinokhovat
fix(manager): add repo check before user creation for avoiding duplic…
949e4e5 
…ated users
@abtinokhovat
test(manager): add test for login and register
2690d1c
@abtinokhovat
refactor(manager): rename service and repository package name
4341d93
@abtinokhovat abtinokhovat added the enhancement New feature or request label Dec 14, 2023
@abtinokhovat abtinokhovat self-assigned this Dec 14, 2023
gocastsian
gocastsian reviewed Dec 23, 2023
View reviewed changes
@abtinokhovat
Copy link
Contributor Author

all problems are now resolved @gohossein
we can merge the PR now .

@abtinokhovat abtinokhovat mentioned this pull request Dec 30, 2023
Merged
gocastsian
gocastsian approved these changes Dec 31, 2023
View reviewed changes
Copy link
Contributor

@gocastsian gocastsian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damet Garm!

@gocastsian gocastsian merged commit 798b87a into ormushq:main Dec 31, 2023
2 checks passed
iam-benyamin pushed a commit to iam-benyamin/ormus that referenced this pull request Jan 5, 2024
@abtinokhovat @sinaw369 @iam-benyamin
feat(manager): register user with email (ormushq#37)
a7331dc 
Co-authored-by: sina hatami <[email protected]>
Co-authored-by: sina hatami <[email protected]>
@sinaw369 sinaw369 deleted the registerEmail branch January 6, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mdhesari Mdhesari Mdhesari left review comments

@sinaw369 sinaw369 sinaw369 left review comments

@gocastsian gocastsian gocastsian approved these changes

@gohossein gohossein Awaiting requested review from gohossein

Assignees

@abtinokhovat abtinokhovat

@sinaw369 sinaw369

Labels
enhancement New feature or request
Projects
Ormus
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abtinokhovat @Mdhesari @sinaw369 @gocastsian