fix: hydra use job.serviceAccount.name when using an existing sa

[dotdc]

Related Issue or Design Document

As described in #767, this pull request will allow to use an existing Kubernetes service account for job when not creating it through the chart.

hydra:
  automigration:
    enabled: true

deployment:
  serviceAccount:
    create: false
    name: "hydra-deploy-sa"

job:
  serviceAccount:
    create: false
    name: "hydra-job-sa"

fixes #767

Checklist

• I have read the contributing guidelines and signed the CLA.
• I have referenced an issue containing the design document if my change introduces a new feature.
• I have read the security policy.
• I confirm that this pull request does not address a security vulnerability.
  If this pull request addresses a security vulnerability,
  I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
• I have added tests that prove my fix is effective or that my feature works.
• I have added the necessary documentation within the code base (if appropriate).

Further comments

[CLAassistant]

All committers have signed the CLA.

[Demonsthere]

Hi there!
Please add a new values.yaml here so that this case will be tested by the ci. I would suggest creating a new sa here and then load it via values :)

[dotdc]

Hi @Demonsthere,
Just added the two ServiceAccounts and copied the default values file with the added deployment.serviceAccount and job.serviceAccount blocks inside (left all the rest as is).

[dotdc]

@Demonsthere CI is failing because the files are not part of the previous release,
Do you think it's worth testing this case specifically? We could also try to adapt the CI to fix it.
Wdyt?

[Demonsthere]

Hey @dotdc! I think the CI issue is important, as in general it blocks the addition of new values variants 🤔. It is not a blocker for this PR, but something that needs to be fixed for the next release to be working. I will add a solution to the master branch, so the tests here can pass