Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do not automatically add verification hook #4342

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

David-Wobrock
Copy link
Contributor

@David-Wobrock David-Wobrock commented Mar 18, 2025

Instead, it should be configured explicitly if we want emails to be sent during registration.

In the current state, this is a breaking change.

Related issue(s)

Relates to #4161

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@David-Wobrock David-Wobrock force-pushed the feat/do-not-automatically-add-verification-hook branch 3 times, most recently from 457f055 to 5dc8997 Compare March 18, 2025 14:33
Instead, it should be configured explicitly if we want emails to be sent during registration.

In the current state, this is a breaking change.
@David-Wobrock David-Wobrock force-pushed the feat/do-not-automatically-add-verification-hook branch from 5dc8997 to be8a5e9 Compare March 18, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant