Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build on 32-bit architectures #821

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix: build on 32-bit architectures #821

merged 1 commit into from
Nov 13, 2024

Conversation

zepatrik
Copy link
Member

@zepatrik zepatrik commented Nov 13, 2024

The implicit type conversions of untyped ints did overflow on 32-bit int sized architectures.

failed to build for linux_arm_6: exit status 1: # github.com/ory/x/hasherx
Error: /go/pkg/mod/github.com/ory/[email protected]/hasherx/hash_comparator.go:168:18: math.MaxUint32 (untyped int constant 4294967295) overflows int
Error: /go/pkg/mod/github.com/ory/[email protected]/hasherx/hash_comparator.go:178:17: math.MaxUint32 (untyped int constant 4294967295) overflows int
Error: /go/pkg/mod/github.com/ory/[email protected]/hasherx/hash_comparator.go:211:18: math.MaxUint32 (untyped int constant 4294967295) overflows int
Error: /go/pkg/mod/github.com/ory/[email protected]/hasherx/hash_comparator.go:221:17: math.MaxUint32 (untyped int constant 4294967295) overflows int
# github.com/ory/x/mapx
Error: /go/pkg/mod/github.com/ory/[email protected]/mapx/type_assert.go:100:10: math.MaxInt64 (untyped int constant 9223372036854775807) overflows uint

@zepatrik zepatrik merged commit 473ec78 into master Nov 13, 2024
10 checks passed
@zepatrik zepatrik deleted the fix/build-on-32-bit branch November 13, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant