Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XUnit parser softfail scenario #6264

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pdostal
Copy link
Member

@pdostal pdostal commented Mar 7, 2025

The test case result was not properly set. This fixes it.

@pdostal pdostal marked this pull request as draft March 7, 2025 08:20
Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid the repeated calls to $out->tag.

Maybe you can also add better tests this time.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (a5ee6da) to head (06d1f7a).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6264   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files         398      398           
  Lines       40017    40019    +2     
=======================================
+ Hits        39623    39625    +2     
  Misses        394      394           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pdostal pdostal marked this pull request as ready for review March 7, 2025 09:52
@pdostal pdostal force-pushed the XUnit_softfail branch 9 times, most recently from b6b91d4 to 0cd337d Compare March 10, 2025 07:14
@pdostal pdostal requested a review from Martchus March 10, 2025 07:16
@pdostal pdostal force-pushed the XUnit_softfail branch 3 times, most recently from d026059 to a6d9094 Compare March 10, 2025 08:21
The test suite result works but for testcase that was not the case.
This fixes it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants