Repository navigation
feat: delete a machine from admission, and delete machines that stop reporting - #890
Merged
Merged
Conversation
retr0h
force-pushed
the
feat/admission
branch
from
November 19, 2026 05:44
6db8390 to
689a08f
Compare
retr0h
force-pushed
the
feat/revoke-stale
branch
from
November 19, 2026 06:02
7770766 to
275bfca
Compare
…reporting
DELETE /api/admission/{machine_id} (osapi client admission delete) removes a
machine's key and each record of it, and keeps none: a machine that asks
again is new. It is for a machine that goes away on purpose, such as a VM
that is rebuilt. Revoke stays for a machine that is not trusted.
controller.pki.delete_after deletes an admitted machine that has not reported
for that long, by its last report or, when it never reported, its admission.
An online machine is never deleted, and when the registry or the last reports
do not read, nothing is deleted. Empty is never.
Closes #889
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
retr0h
force-pushed
the
feat/revoke-stale
branch
from
November 19, 2026 06:04
275bfca to
35ef17a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #890 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 556 557 +1
Lines 30523 30594 +71
=========================================
+ Hits 30523 30594 +71
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #889.
Specs: osapi-io/specs#376
Rebased onto
mainafter #887 merged.What changes
DELETE /api/admission/{machine_id}(osapi client admission delete) removes a machine's key and each record of it, and keeps none. A machine that asks again is new. It is for a machine that goes away on purpose, such as a VM that is rebuilt. Revoke stays for a machine that is not trusted. It has an SDKDelete, a UI Delete button with a second-click confirm, and theadmission.deletespan.controller.pki.delete_after: deletes an admitted machine that has not reported for that long, by its last report or, when it never reported, by its admission time. An online machine is never deleted. When the registry or the last reports do not read, nothing is deleted. Empty, the default, is never.Checks
internal/controller/admission,internal/controller/endpoints/admission,internal/controllerand the SDK admission files are at 100%.cmdpasses.golangci-lint: 0 issues.just react-testpasses.🤖 Generated with Claude Code