Started making the CLI #368
Conversation
|
Please make PR against the dev branch. |
|
Needs plenty of changes. Some of these may be delayable until later, but ideally do them first:
|
| osdag = "osdag.osdagMainPage:do_stuff" | ||
|
|
||
| [project.scripts] | ||
| osdag-cli = "osdag_cli:testing" |
There was a problem hiding this comment.
Please keep osdag_cli under the osdag module (so it should read osdag.osdag_cli:testing). Also, change name of the method to something less temporary. Can main do the job?
| # Reads a plain text file line by line, extracts the 'Module' field, | ||
| # and determines the module type. |
There was a problem hiding this comment.
| # Reads a plain text file line by line, extracts the 'Module' field, | |
| # and determines the module type. | |
| # Given an Osdag input file (.osi), extracts the 'Module' field, | |
| # and determines the module type. |
| # with open(file_path, 'r') as file: | ||
| # for line in file: | ||
| # # Check if the line contains the 'Module' field | ||
| # if line.startswith("Module:"): | ||
| # # Extract and print the module name | ||
| # module_name = line.split(':', 1)[1].strip() | ||
| # click.echo(f"Module: {module_name}") | ||
| # return |
There was a problem hiding this comment.
I recall in a recent meeting you showed this code as working. Have you not updated the changes here?
| 'console_scripts': [ | ||
| 'osdag-cli = osdag_cli:determine_module', | ||
| ], |
There was a problem hiding this comment.
This may get us too many entry points. OK for testing, but eventually we want something like:
osdag-cli --determine-module <filename>
| @@ -0,0 +1,17 @@ | |||
| # setup.py | |||
There was a problem hiding this comment.
We're already using pyproject.toml, which is a more modern method. Probably safe to delete.
3 participants
No description provided.