feat: Add credential submission and tracking #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nagement on frontend
# Conflicts: # client/src/App.tsx # client/src/components/Navbar.tsx # client/src/pages/Home.tsx # client/src/pages/Login.tsx # client/src/pages/Profile.tsx # client/src/types.ts
SamLarivs
reviewed
Oct 30, 2024
| .catch((error) => console.warn('Could not fetch events: ', error)); | ||
| .catch((error) => { | ||
| if (error === '403: Forbidden') | ||
| setError('Please enter AWS Credentials to view events'); |
SamLarivs
reviewed
Oct 30, 2024
| @@ -1,21 +1,18 @@ | |||
| import React, { lazy, useState } from 'react'; | |||
There was a problem hiding this comment.
I'm the lazy loading didnt turn out to be a home run. I wonder how many other issues were stemming from it. Maybe there's a better use case for it in larger applications.
SamLarivs
reviewed
Oct 30, 2024
| RETURNING *; | ||
| `, | ||
| [ | ||
| res.locals.awsCredentials.aws_access_key, |
SamLarivs
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue/ticket
#29
Description
Connects the credential entry fields on the profile page to the backend.
The database now tracks AWS credentials in the users table.
The frontend tracks user information including AWS credentials in localstorage
This allows session managment.
Routing also now works by restricting access to information that requires a login, or credentials set
Reproduction steps
You will need to run
npm run docker-remove-allso that the users table can be rebuilt with the aws credential columnsStart up the app, and try to navigate to the homepage, events dashboard, or profile. You will be told you need to login first.
Since you deleted the database volume, you'll need to sign up as a new user, and then log in.
Try to access the events dashboard. You will be told you need to enter your AWS credentials.
Back on the profile page, enter your AWS credentials. After dismissing the popup, you can now view events on the dashboard and charts on the homepage.
If you close your browser and reopen, you should be able to click login, and it will automatically log you in with your stored user session data.
If you want to change your AWS credentials at any time, you can in the profile page.
Checklist