Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: routing fix #82

Merged
merged 5 commits into from
Oct 31, 2024
Merged

fix: routing fix #82

merged 5 commits into from
Oct 31, 2024

Conversation

aidanprior
Copy link
Collaborator

@aidanprior aidanprior commented Oct 30, 2024

Linked issue/ticket

Description

Makes a small fix to the frontend routing.
Fixes some edge cases for session management

Reproduction steps

Checklist

  • I've followed the Contributing guidelines
  • I've titled my PR according to the Conventional Commits spec
  • I've added tests that fail without this PR but pass with it
  • I've linted, tested, and commented my code
  • I've updated documentation (if appropriate)

@aidanprior aidanprior marked this pull request as draft October 30, 2024 16:42
@aidanprior aidanprior marked this pull request as ready for review October 31, 2024 16:12
@SamLarivs SamLarivs self-assigned this Oct 31, 2024
@@ -15,7 +14,7 @@ export default {
}
process.env.AWS_ACCESS_KEY_ID = aws_access_key;
process.env.AWS_SECRET_ACCESS_KEY = aws_secret_access_key;
process.env.AWS_aws_region = aws_region;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol.

Copy link
Contributor

@SamLarivs SamLarivs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! thank you, Aidan.

@SamLarivs SamLarivs merged commit 8b19400 into dev Oct 31, 2024
3 checks passed
@SamLarivs SamLarivs deleted the aidanprior/routingFix branch October 31, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants