Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On startup, the app will now download the same indicators as mvt, parsing indicators.yaml. It saves the timestamp of the last check and last successful downloads, and checks per-indicator commits via the Github API. The count of indicators, the last update and the last update check are viewable in the options.
Then, it decouples the concept of acquisition from the concept of checking for indicators. In this way, when indicators are updated, user can scan old acquisitions if they have any. In the future we might do this in the background, so that we can alert users if we gain new intel on spyware or stalkerware even if they re no longer infected or traces are not currently existing on the system.
A first IOC check is done at the end of the acquisition, and the user can then manually run it again any time they want. The hash indicating the indicators version is currently just a hash of all .stix files chained together.