Use FOREGROUND_SERVICE_TYPE_SHORT_SERVICE for adb pairing#56
Merged
Conversation
Member
|
Tested it and everything seems to be working fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of
FOREGROUND_SERVICE_TYPE_SPECIAL_USE, which requires an additional permission and special explanation in the manifest, useFOREGROUND_SERVICE_TYPE_SHORT_SERVICEfor adb pairing. More info: https://developer.android.com/reference/android/content/pm/ServiceInfo#FOREGROUND_SERVICE_TYPE_SHORT_SERVICETested briefly on an EOL (pre-API 34) Android device, and pairing is still successful. I have not tested the pairing and full acquisition workflow, so a diligent test plan would include that, but it should not be affected--the only foregrounded service is the pairing service.
Testing: