Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libmvt is a big component of Bugbane that is used to parse mvt-like acquisitions.
testing it on Android is burdensome, sometimes you want to parse multiple time an acquisition and check what is going wrong. this need an Android build + emulation every time.
also its tests cannot be done with simple JUnit tests cause of the Android dependency.
for all of the above reasons, libmvt is now a standalone component that runs both on Android and on the JVM.
this PR removes the bundled libmvt component in Bugbane and instead pull the standalone libmvt from https://jitpack.io.
for now jitpack.io is ok, in the future we might want to build our own releases and sign them, and also sign tags
this PR also adds a
libmvtLocalgradle property in case the developer wants to compile Bugbane with a local version oflibmvtinstead of a remote one