Skip to content

analyser: Fix logic of test file analyser for non standalone run #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

arthurscchan
Copy link
Contributor

This PR fixes the logic of the test file analyser for non-standalone runs. Since some projects do not include the complete source code within the Introspector project as a result of test files are being ignored during the general report run. This PR introduces an additional round of frontend runs to ensure the required test files are present before proceeding with the analysis. It also improves the source path discovery logic when paths are not explicitly provided, by identifying the common path among existing source files and including the mandatory /src path if it exists. These changes enhance compatibility with both OSS-Fuzz report runs and standalone analysis runs.

Signed-off-by: Arthur Chan <[email protected]>
Signed-off-by: Arthur Chan <[email protected]>
Signed-off-by: Arthur Chan <[email protected]>
@arthurscchan arthurscchan marked this pull request as ready for review May 8, 2025 19:16
@DavidKorczynski DavidKorczynski merged commit 8834f17 into ossf:main May 8, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants