-
Notifications
You must be signed in to change notification settings - Fork 73
OSV Schema TI Graduation Application #456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This adds a CONTRIBUTING.md and CODE_OF_CONDUCT.md to address deficiencies and assist with progressing OSV Schema TI Graduation Application (ossf/tac#456) For want of something better, I used what is present at https://github.com/ossf/oss-vulnerability-guide
This adds a CONTRIBUTING.md and CODE_OF_CONDUCT.md to address deficiencies and assist with progressing OSV Schema TI Graduation Application (ossf/tac#456) For want of something better, I used what is present at https://github.com/ossf/oss-vulnerability-guide Signed-off-by: Andrew Pollock <[email protected]> Signed-off-by: Andrew Pollock <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've suggested a few modifications based on conversations with related parties
process/project-lifecycle-documents/osv-schema_graduation_stage.md
Outdated
Show resolved
Hide resolved
process/project-lifecycle-documents/osv-schema_graduation_stage.md
Outdated
Show resolved
Hide resolved
process/project-lifecycle-documents/osv-schema_graduation_stage.md
Outdated
Show resolved
Hide resolved
process/project-lifecycle-documents/osv-schema_graduation_stage.md
Outdated
Show resolved
Hide resolved
This adds a CONTRIBUTING.md and CODE_OF_CONDUCT.md to address deficiencies and assist with progressing OSV Schema TI Graduation Application (ossf/tac#456) For want of something better, I used what is present at https://github.com/ossf/oss-vulnerability-guide Signed-off-by: Andrew Pollock <[email protected]> Signed-off-by: Andrew Pollock <[email protected]>
process/project-lifecycle-documents/osv-schema_graduation_stage.md
Outdated
Show resolved
Hide resolved
process/project-lifecycle-documents/osv-schema_graduation_stage.md
Outdated
Show resolved
Hide resolved
process/project-lifecycle-documents/osv-schema_graduation_stage.md
Outdated
Show resolved
Hide resolved
| * The project has a standing agenda item in the Vulnerability Disclosures Working Group meetings. [Meeting Notes](https://docs.google.com/document/d/1TdxiFofLOfpHUEQILlKq7qkjSsRXVab0uApSDJ8c5rI/edit?tab=t.0) | ||
|
|
||
| Implements, practices, and refines mature software development and release practices, such as adherence to semantic versioning, and having a declared policy for stable releases and backported fixes. | ||
| * "link to policy for (or describe here) software development and release practices" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oliverchang can you suggest an edit here to describe the release process of the schema?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it'd be better for that to be in something like a RELEASING.md in the osv-schema repo, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will take a look at making a RELEASING.md file, the current release process is pretty simple:
- Bump up the version (patch version bump for new ecosystems, minor version bump for non breaking schema field changes)
- Add schema changes to the changelog
- Publish github release
- Update the github pages branch to the new release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this!
process/project-lifecycle-documents/osv-schema_graduation_stage.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Jeff Diecks <[email protected]>
…e.md Co-authored-by: Andrew Pollock <[email protected]> Signed-off-by: Jeff Diecks <[email protected]>
…e.md Co-authored-by: Andrew Pollock <[email protected]> Signed-off-by: Jeff Diecks <[email protected]>
…e.md Co-authored-by: Andrew Pollock <[email protected]> Signed-off-by: Jeff Diecks <[email protected]>
…e.md Co-authored-by: Andrew Pollock <[email protected]> Signed-off-by: CRob <[email protected]>
updating based on Oliver's feedback Signed-off-by: CRob <[email protected]>
…e.md Co-authored-by: Andrew Pollock <[email protected]> Signed-off-by: Jeff Diecks <[email protected]>
e28c7eb to
e7f7d7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's really exciting to see OSV schema reach this stage! That said, I would like to see a clearer roadmap for a project at this maturity level, so I hope that we can start to clarify this as part of this process.
| * https://github.com/ossf/osv-schema/blob/main/CHARTER.md | ||
|
|
||
| Have a defined and documented roadmap and annual goals for the project | ||
| * https://github.com/ossf/osv-schema/projects?query=is%3Aopen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The project board is currently empty. Do you a have a sense for the open issues (or other tasks) you might prioritize next?
| * https://github.com/ossf/osv-schema/projects?query=is%3Aopen | ||
|
|
||
| Project has met at least 4 times over a period of at least 2 months since becoming incubating | ||
| * The project has a standing agenda item in the Vulnerability Disclosures Working Group meetings. [Meeting Notes](https://docs.google.com/document/d/1TdxiFofLOfpHUEQILlKq7qkjSsRXVab0uApSDJ8c5rI/edit?tab=t.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the requirements for graduation, there doesn't seem to be a lot of discussion about OSV in recent meetings. Per my comment about prioritization above, once this application is completed, do you have a sense for what's next?
| |-----------------------|-----| | ||
| | Repo | https://github.com/ossf/osv-schema | | ||
| | Website | https://ossf.github.io/osv-schema/ | | ||
| | Contributing guide | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add the link to the CONTRIBUTING.md file?
| ## Project graduation application | ||
|
|
||
| ### Project has met all Incubating requirements | ||
| * n/a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this said to be not applicable? It is not optional. A project doesn't have to go through every step of the lifecycle and may apply for a status at any level but it still needs to fulfill all the requirements for the previous ones.
|
This PR should also include the related necessary change to be made to the table in the README.md file. |
|
|
||
| ### Security Baseline | ||
|
|
||
| The project meets all applicable Security Baseline requirements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there are some open issues with respect to meeting the security baseline: https://github.com/ossf/osv-schema/issues?q=state%3Aopen%20label%3A%22security%20baseline%22
| * The project has a standing agenda item in the Vulnerability Disclosures Working Group meetings. [Meeting Notes](https://docs.google.com/document/d/1TdxiFofLOfpHUEQILlKq7qkjSsRXVab0uApSDJ8c5rI/edit?tab=t.0) | ||
|
|
||
| Implements, practices, and refines mature software development and release practices, such as adherence to semantic versioning, and having a declared policy for stable releases and backported fixes. | ||
| * "link to policy for (or describe here) software development and release practices" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * "link to policy for (or describe here) software development and release practices" | |
| * https://github.com/ossf/osv-schema/blob/main/RELEASING.md |
| |-----------------------|-----| | ||
| | Repo | https://github.com/ossf/osv-schema | | ||
| | Website | https://ossf.github.io/osv-schema/ | | ||
| | Contributing guide | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| | Contributing guide | | | |
| | Contributing guide | https://github.com/ossf/osv-schema/blob/main/CONTRIBUTING.md | |
This is an initial draft of the application with some of the basic information included. Submitting as a draft PR to allow for contributions from others collaborating on this app.