Skip to content

Conversation

@epifanio
Copy link

Update ossimPlanetKmlScreenOverlayNode.h to OSG 3.4

@epifanio epifanio changed the title dev ossimPlanetKmlScreenOverlayNode - OSG 3.4 compatibility Jul 30, 2016
@epifanio epifanio mentioned this pull request Jul 30, 2016
@gpotts
Copy link
Member

gpotts commented Aug 9, 2016

Hello:

HAve these mods now alllow a complete build for OSG 3.4 without errors?

Take care

Garrett

On Jul 30, 2016, at 7:41 AM, epifanio [email protected] wrote:

Update ossimPlanetKmlScreenOverlayNode.h to OSG 3.4

You can view, comment on, or merge this pull request online at:

#2 #2
Commit Summary

Update to OSG 3.4
File Changes

M include/ossimPlanet/ossimPlanetKmlScreenOverlayNode.h https://github.com/ossimlabs/ossim-planet/pull/2/files#diff-0 (4)
Patch Links:

https://github.com/ossimlabs/ossim-planet/pull/2.patch https://github.com/ossimlabs/ossim-planet/pull/2.patch
https://github.com/ossimlabs/ossim-planet/pull/2.diff https://github.com/ossimlabs/ossim-planet/pull/2.diff

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub #2, or mute the thread https://github.com/notifications/unsubscribe-auth/ACL9v2-oYxbi6mZRk-l1E24TPYY32Evuks5qaziAgaJpZM4JYyfo.

@epifanio
Copy link
Author

this fix the kmloverlay issue, but then the build fail on:

[ 81%] Building CXX object ossimPlanet/CMakeFiles/ossim-planet.dir/src/ossimPlanet/ossimPlanetKmlPlacemarkNode.cpp.o
/Users/epi/dev/src/ossim/ossimPlanet/src/ossimPlanet/ossimPlanetKmlPlacemarkNode.cpp:506:44: error: no matching constructor for initialization of
      'ossimPlanetKmlTextShiftUpdate'
               text->setUpdateCallback(new ossimPlanetKmlTextShiftUpdate(billboardIcon.get(),
                                           ^                             ~~~~~~~~~~~~~~~~~~~~
/Users/epi/dev/src/ossim/ossimPlanet/src/ossimPlanet/ossimPlanetKmlPlacemarkNode.cpp:176:4: note: candidate constructor not viable: no known conversion from
      'osg::Callback *' to 'osg::ref_ptr<osg::Drawable::UpdateCallback>' for 3rd argument
   ossimPlanetKmlTextShiftUpdate(ossimPlanetBillboardIcon* icon,
   ^
/Users/epi/dev/src/ossim/ossimPlanet/src/ossimPlanet/ossimPlanetKmlPlacemarkNode.cpp:173:7: note: candidate constructor (the implicit copy constructor) not viable:
      requires 1 argument, but 3 were provided
class ossimPlanetKmlTextShiftUpdate : public osg::Drawable::UpdateCallback
      ^
1 error generated.
make[2]: *** [ossimPlanet/CMakeFiles/ossim-planet.dir/src/ossimPlanet/ossimPlanetKmlPlacemarkNode.cpp.o] Error 1
make[1]: *** [ossimPlanet/CMakeFiles/ossim-planet.dir/all] Error 2
make: *** [all] Error 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants