-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/sctp: support sctp data channel #3494
base: develop
Are you sure you want to change the base?
Conversation
9bf0870
to
162cb17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refer to https://github.com/ossrs/srs-sctp/commit/d84928a7f9065114400b0c93980fd0f6900d9dc9
, fuzzer
and programs
do not need to be uploaded.
TRANS_BY_GPT3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
TRANS_BY_GPT3
trunk/auto/depends.sh
Outdated
) | ||
fi | ||
# check status | ||
ret=$?; if [[ $ret -ne 0 ]]; then echo "Build usrsctp failed, ret=$ret"; exit $ret; fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If libtool
is not installed, it will fail. You should add a prompt to guide the user to install it. For example,
if [[ $ret -ne 0 ]]; then
Build usrsctp failed, ret=$ret";
if [[ $OS_IS_CENTOS == YES ]]; then
echo "Please install libtool by:"
echo " yum install -y libtool"
elif [[ $OS_IS_UBUNTU == YES ]]; then
echo "Please install libtool by:"
echo " apt install -y libtool"
fi
exit $ret;
fi
TRANS_BY_GPT3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
补充了" translates to "supplemented" in English.
TRANS_BY_GPT3
a506bab
to
4a55287
Compare
trunk/src/app/srs_app_rtc_api.cpp
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SrsGoApiRtcPublish::check_remote_sdp
also needs to support application, right?
TRANS_BY_GPT3
trunk/src/app/srs_app_rtc_server.cpp
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/rtc/v1/data/
can be considered for deletion. Because application
, video
, and audio
may be generated simultaneously, a single SDP exchange is sufficient. The rtc/v1/publish
and rtc/v1/play
interfaces can be reused.
TRANS_BY_GPT3
a6fee98
to
3905d83
Compare
This reverts commit a6fee98.
0bb9637
to
2e211f6
Compare
support sctp data channel,
add page /players/rtc_datachannel.html