improve http response when err happens. #4073
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. response 200 with code when rtc/v1 remote sdp parse error; 2. response 500 when no handled err.
winlinvip
force-pushed
the
develop
branch
2 times, most recently
from
0bb9637
to
2e211f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to improve two problem:
let
rtc/v1/[whep|whip]response 200 with body{code : 400}whenremote_sdpparse error happen by followrtc/v1/[play | publish]api's response. The current behavior in this scenario is close the connection without response anything.Let
SrsHttpServeMuxresponse 500 when err not handled, the current behavior is also to close the socket connection without response anything.